Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune](deps): Bump wandb from 0.10.29 to 0.10.32 in /python/requirements/tune #10

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jun 23, 2021

Bumps wandb from 0.10.29 to 0.10.32.

Changelog

Sourced from wandb's changelog.

0.10.32 (June 10, 2021)

🐛 Bug Fix

  • Make log_artifact() more resilient to network errors
  • Removed Duplicate Artifact Dependencies
  • Workaround urlib3 issue on windows
  • Fix regression where ipython was hanging
  • Allow logging of numpy high precision floating point values
  • Reduce liklyhood of collisions for file backed media or artifact objects
  • Fix wandb.watch() regression when logging pytorch graphs

💅 Enhancement

  • Add support for logging joined and partitioned table
  • Handle schema validation warnings for sweep configs
  • Improve wandb sync to handle errors
  • Add ability to label scripts and repositories who use wandb

0.10.31 (May 27, 2021)

🐛 Bug Fix

  • wandb.login() did not properly persist the host parameter
  • Fix issue where step information was not synced properly when syncing tensorboard directories
  • Fix some unicode issues with python2.7
  • Fixed bug in plot_calibration_curve for ComplementNB
  • Fall back to not using SendFile on some linux systems
  • Fix console issues where lines were truncated
  • Fix console issues where console logging could block

💅 Enhancement

  • Add support for preemptible sweeps
  • Add command line for sweep control
  • Add support to load artifact collection properties

0.10.30 (May 7, 2021)

🐛 Bug Fix

  • Found and fixed the remaining issues causing runs to be marked crashed during outages
  • Improved performance for users of define_metric, pytorch-lightning, and aggressive config saving
  • Fix issue when trying to log a cuda tensor to config or summary
  • Remove dependancy on torch backward_hooks to compute graph
  • Fix an issue preventing the ability to resume runs on sagemaker
  • Fix issues preventing pdb from working reliably with wandb
  • Fix deprecation warning in vendored library (user submission)
  • Fix logging behavior where the library was accidently outputting logs to the console
  • Fix disabled mode to not create wandb dir and log files

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [wandb](https://github.com/wandb/client) from 0.10.29 to 0.10.32.
- [Release notes](https://github.com/wandb/client/releases)
- [Changelog](https://github.com/wandb/client/blob/master/CHANGELOG.md)
- [Commits](wandb/wandb@v0.10.29...v0.10.32)

---
updated-dependencies:
- dependency-name: wandb
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 23, 2021
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jul 3, 2021

Superseded by #16.

@dependabot dependabot bot closed this Jul 3, 2021
@dependabot dependabot bot deleted the dependabot/pip/python/requirements/tune/wandb-0.10.32 branch July 3, 2021 07:05
gramhagen pushed a commit that referenced this pull request Aug 12, 2022
We encountered SIGSEGV when running Python test `python/ray/tests/test_failure_2.py::test_list_named_actors_timeout`. The stack is:

```
#0  0x00007fffed30f393 in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(std::string const&) ()
   from /lib64/libstdc++.so.6
#1  0x00007fffee707649 in ray::RayLog::GetLoggerName() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#2  0x00007fffee70aa90 in ray::SpdLogMessage::Flush() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#3  0x00007fffee70af28 in ray::RayLog::~RayLog() () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#4  0x00007fffee2b570d in ray::asio::testing::(anonymous namespace)::DelayManager::Init() [clone .constprop.0] ()
   from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#5  0x00007fffedd0d95a in _GLOBAL__sub_I_asio_chaos.cc () from /home/admin/dev/Arc/merge/ray/python/ray/_raylet.so
#6  0x00007ffff7fe282a in call_init.part () from /lib64/ld-linux-x86-64.so.2
#7  0x00007ffff7fe2931 in _dl_init () from /lib64/ld-linux-x86-64.so.2
#8  0x00007ffff7fe674c in dl_open_worker () from /lib64/ld-linux-x86-64.so.2
#9  0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#10 0x00007ffff7fe5ffe in _dl_open () from /lib64/ld-linux-x86-64.so.2
#11 0x00007ffff7d5f39c in dlopen_doit () from /lib64/libdl.so.2
#12 0x00007ffff7b82e79 in _dl_catch_exception () from /lib64/libc.so.6
#13 0x00007ffff7b82f13 in _dl_catch_error () from /lib64/libc.so.6
#14 0x00007ffff7d5fb09 in _dlerror_run () from /lib64/libdl.so.2
#15 0x00007ffff7d5f42a in dlopen@@GLIBC_2.2.5 () from /lib64/libdl.so.2
#16 0x00007fffef04d330 in py_dl_open (self=<optimized out>, args=<optimized out>)
    at /tmp/python-build.20220507135524.257789/Python-3.7.11/Modules/_ctypes/callproc.c:1369
```

The root cause is that when loading `_raylet.so`, `static DelayManager _delay_manager` is initialized and `RAY_LOG(ERROR) << "RAY_testing_asio_delay_us is set to " << delay_env;` is executed. However, the static variables declared in `logging.cc` are not initialized yet (in this case, `std::string RayLog::logger_name_ = "ray_log_sink"`).

It's better not to rely on the initialization order of static variables in different compilation units because it's not guaranteed. I propose to change all `RAY_LOG`s to `std::cerr` in `DelayManager::Init()`.

The crash happens in Ant's internal codebase. Not sure why this test case passes in the community version though.

BTW, I've tried different approaches:

1. Using a static local variable in `get_delay_us` and remove the global variable. This doesn't work because `init()` needs to access the variable as well.
2. Defining the global variable as type `std::unique_ptr<DelayManager>` and initialize it in `get_delay_us`. This works but it requires a lock to be thread-safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants